Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State dir cleanup #7606

Merged
merged 3 commits into from
May 5, 2023
Merged

State dir cleanup #7606

merged 3 commits into from
May 5, 2023

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented May 4, 2023

closes: #7591

Description

Uses a different stateDir for swingset (and its swingstore): $AG_CHAIN_COSMOS_HOME/data/agoric. This will allow validator operators to safely remove the old dir $AG_CHAIN_COSMOS_HOME/data/ag-cosmos-chain-state after verifying they didn't stash anything in there.

This also clean up some code cruft left behind after moving Swingstore to SQLite and placing transcripts and heap snapshots in consensus.

Security Considerations

None

Scaling Considerations

Allows validators to perform an easier housekeeping

Documentation Considerations

This change should be communicated to validators. Not sure where the runbook issue is?

Testing Considerations

Deployment test will exercise all these changes

mhofman added 3 commits May 4, 2023 13:13
No longer needed or functional. It's all in consensus nowadays!
To `agoric` subfolder of `$AG_CHAIN_COSMOS_HOME/data`
@mhofman mhofman requested a review from michaelfig May 4, 2023 13:39
@mhofman mhofman added the automerge:rebase Automatically rebase updates, then merge label May 4, 2023
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll leave it at your discretion if you want to search for all .ag-chain-cosmos and replace with .agd.

@@ -237,7 +237,7 @@ export const main = async (
`${processValue.getFlag(
'home',
`${homedir}/.ag-chain-cosmos`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, this default location has changed, too.

Suggested change
`${homedir}/.ag-chain-cosmos`,
`${homedir}/.agd`,

@@ -152,7 +152,7 @@ export const main = async (
`${processValue.getFlag(
'home',
`${homedir}/.ag-chain-cosmos`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

@mhofman mhofman added this pull request to the merge queue May 5, 2023
Merged via the queue into master with commit 930595b May 5, 2023
@mhofman mhofman deleted the mhofman/7591-switch-state-dir branch May 5, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable cleanup old swingset state on bulldozer
2 participants